-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Not possible to play with generative art drop page when not connected #7895
Conversation
SUCCESS @Jarsen136 PR for issue #7888 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes changes to the drop functionality of a generative art collection. It resolves the issue where users were unable to interact with the generative art drop page when not connected. The patch modifies two vue files: In In These changes are intended to improve user experience by enabling interaction with the generative art drop page even when users are not connected. |
Code Climate has analyzed commit 1797bfe and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Jarsen136 i think one point could be improved, let's say I'm disconnected and i find one image i like, i click on connect wallet, but as soon as i connect, the page runs the generate new automatically and i lose that image i wanted. (same happens when disconnecting) |
It was implemented purposely like that because the image consists of the current address and a random value. When you connect/disconnect the wallet, the image will change accordingly. @prury |
hmm i see, ok then i guess |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
copilot:summary
copilot:poem