Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not possible to play with generative art drop page when not connected #7895

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 30, 2023 17:25
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team October 30, 2023 17:25
@kodabot
Copy link
Collaborator

kodabot commented Oct 30, 2023

SUCCESS @Jarsen136 PR for issue #7888 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1797bfe
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653fe722e3a7e10008bc5282
😎 Deploy Preview https://deploy-preview-7895--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 30, 2023

AI-Generated Summary: This pull request includes changes to the drop functionality of a generative art collection. It resolves the issue where users were unable to interact with the generative art drop page when not connected. The patch modifies two vue files: Generative.vue and GenerativePreview.vue.

In Generative.vue, a condition has been added to disable the mint button if the user is not connected (i.e., no accountId is available).

In GenerativePreview.vue, the generateNft function has been updated to handle cases where no accountId is available. The function now defaults to a random ss58Format value when there's no accountId. Moreover, generateNft function is now called on accountId changes instead of just on component mount.

These changes are intended to improve user experience by enabling interaction with the generative art drop page even when users are not connected.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 30, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit 1797bfe and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@prury
Copy link
Member

prury commented Oct 30, 2023

@Jarsen136 i think one point could be improved, let's say I'm disconnected and i find one image i like, i click on connect wallet, but as soon as i connect, the page runs the generate new automatically and i lose that image i wanted. (same happens when disconnecting)

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Oct 30, 2023
@Jarsen136
Copy link
Contributor Author

@Jarsen136 i think one point could be improved, let's say I'm disconnected and i find one image i like, i click on connect wallet, but as soon as i connect, the page runs the generate new automatically and i lose that image i wanted. (same happens when disconnecting)

It was implemented purposely like that because the image consists of the current address and a random value. When you connect/disconnect the wallet, the image will change accordingly. @prury

@prury
Copy link
Member

prury commented Oct 31, 2023

@Jarsen136 i think one point could be improved, let's say I'm disconnected and i find one image i like, i click on connect wallet, but as soon as i connect, the page runs the generate new automatically and i lose that image i wanted. (same happens when disconnecting)

It was implemented purposely like that because the image consists of the current address and a random value. When you connect/disconnect the wallet, the image will change accordingly. @prury

hmm i see, ok then i guess

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Oct 31, 2023
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit 4041b34 into kodadot:main Nov 1, 2023
11 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.34 USD/DOT ~ 6.912 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x7c06de29d7a71c9c987018d287a5d1158c9c5885c2de9ab2a3f27b0bf2832fd9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 1, 2023
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to play with generative art drop page when not connected
6 participants