Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint to should not emit transfer #133

Open
vikiival opened this issue Oct 25, 2023 · 3 comments
Open

Mint to should not emit transfer #133

vikiival opened this issue Oct 25, 2023 · 3 comments
Milestone

Comments

@vikiival
Copy link
Member

vikiival commented Oct 25, 2023

Implement that mint handler should not emit transfer event.

Describe the bug

https://kodadot.xyz/ahp/gallery/10-24

The drops are calling nfts.mint(collection, sn, address, null)

From some reason the mint to is also creating an additional event of transfer (that basically never happened)

To Reproduce

Create and nft in any https://kodadot.xyz/drops

Expected behavior

MINT_TO should mark TO as the minter of the particular NFT

Screenshots

Screenshot 2023-10-25 at 17 01 21

Additional context

@roiLeo
Copy link
Contributor

roiLeo commented Oct 30, 2023

if (final.issuer !== final.currentOwner) {
await createEvent(final, Action.SEND, event, final.currentOwner, context.store, final.issuer)
}

@vikiival
Copy link
Member Author

Was this implemented? Cc @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Feb 13, 2024

Nope, feel free to remove #133 (comment)

@vikiival vikiival added this to the W3F M2 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants