Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter by collection, count tokens #118

Merged
merged 2 commits into from
Oct 17, 2023
Merged

filter by collection, count tokens #118

merged 2 commits into from
Oct 17, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Oct 17, 2023 •
edited by yangwao
Loading

  1. enable filtering by collections
  2. change total count to count tokens, not nftEntites, counting nft entities broke infinite scroll

@daiagi daiagi requested a review from vikiival October 17, 2023 08:32
roiLeo
roiLeo approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to run indexer again?

@daiagi daiagi mentioned this pull request Oct 17, 2023
Merged
8 tasks
@daiagi
Copy link
Contributor Author

daiagi commented Oct 17, 2023

No need to run indexer again?

no need, it's done in resolver
need to deploy again however

@yangwao
Copy link
Member

yangwao commented Oct 17, 2023

cc @vikiival

vikiival
vikiival reviewed Oct 17, 2023
View reviewed changes
src/server-extension/query/tokenEntities.ts
@@ -8,7 +8,8 @@ filters_applied AS (
($7::text[] IS NULL OR ne.issuer NOT IN (SELECT unnest($7))) AND
($4::bigint IS NULL OR ne.price >= $4::bigint) AND
($5::bigint IS NULL OR ne.price > $5::bigint) AND
($6::bigint IS NULL OR ne.price <= $6::bigint)
($6::bigint IS NULL OR ne.price <= $6::bigint) AND
($9::text[] IS NULL OR ne.collection_id = ANY($9))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will go slow

@vikiival vikiival merged commit 6673e66 into kodadot:main Oct 17, 2023
1 check passed
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable popular collections filter on TokenEntity
4 participants
@daiagi @yangwao @roiLeo @vikiival