Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 collection floor #165

Merged
merged 4 commits into from
Jan 6, 2024
Merged

🔧 collection floor #165

merged 4 commits into from
Jan 6, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 18, 2023 •
edited
Loading

maybe something like this could work

vikiival
vikiival requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No
Rather use raw query

@roiLeo roiLeo changed the title 🔧 wip: collection floor 🔧 collection floor Dec 19, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 19, 2023

need to change after #168

vikiival
vikiival approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doable

@roiLeo roiLeo marked this pull request as ready for review December 19, 2023 12:58
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 19, 2023

IMO it's better to use orm instead of raw sql

@vikiival
Copy link
Member

IMO it's better to use orm instead of raw sql

If you can write it effective, feel free.

The implementation introduced in 2a60224 is ineffective and would never resolve.

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 19, 2023

The implementation introduced in 2a60224 is ineffective and would never resolve.

hmmmmmm.. will always be 0n when not listed if I understand correctly

@roiLeo roiLeo mentioned this pull request Jan 4, 2024
Closed
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 6, 2024

Merge?

@vikiival
Copy link
Member

vikiival commented Jan 6, 2024 •
edited
Loading

If you are sure that it works i would merge

@vikiival vikiival merged commit d2e38dc into kodadot:main Jan 6, 2024
2 checks passed
@roiLeo roiLeo deleted the fix/collection/floor branch January 6, 2024 10:14
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 6, 2024

If you are sure that it works i would merge

can we do a smoll release to test it without affecting v8 stick and v9 speck?

@vikiival
Copy link
Member

vikiival commented Jan 6, 2024

We can do a new release, pleas top up stick version :) and do a pr

@roiLeo roiLeo mentioned this pull request Jan 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update collection.floor on buy, burn
2 participants
@roiLeo @vikiival