Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge pipeline #21

Merged
merged 19 commits into from
Apr 30, 2020
Merged

Fix merge pipeline #21

merged 19 commits into from
Apr 30, 2020

Conversation

RobinWijnant
Copy link
Member

@RobinWijnant RobinWijnant commented Apr 29, 2020

See reopened issue #6

  • Removing the execution away from the container is a possible fix for the failing git commit
  • tsc --build or tsc -b is used to only update the changed files. The dist is always deleted so adding this flag is redundant. The verbose flag is also not needed imo.

Closes #6

@RobinWijnant RobinWijnant self-assigned this Apr 29, 2020
@RobinWijnant RobinWijnant added bug Something isn't working devops Working on the build process labels Apr 29, 2020
@RobinWijnant RobinWijnant marked this pull request as draft April 29, 2020 23:23
@RobinWijnant
Copy link
Member Author

The failing git commit is caused by the EndBug/add-and-commit action. I have opened an issue on the repo. See EndBug/add-and-commit#27

@bramvanhoutte
Copy link
Contributor

Is there really not another way of deploying the docs? Because now the PR is always going to be cluttered with the built documentation files

@RobinWijnant
Copy link
Member Author

What do you mean with cluttered? Is the automatic commit bothering you? What do you propose?

@RobinWijnant RobinWijnant force-pushed the 6-basic-ci-setup branch 2 times, most recently from 37818e8 to ab42555 Compare April 30, 2020 08:35
@RobinWijnant RobinWijnant marked this pull request as ready for review April 30, 2020 09:11
@bramvanhoutte
Copy link
Contributor

Right now there are 43 changes. But these are generated build files, meaning they will change every time a new build is done. This means that every pull request will have 40+ changes, which is really annoying to filter through when reviewing.

This reverts commit 40e2f62.
@RobinWijnant
Copy link
Member Author

RobinWijnant commented Apr 30, 2020

Normally the commit with the generated doc folder only occurs after the merge in master. I wanted to test if it worked without waiting for the merge. This leaded to the docs already being commited in this branch. I think this was confusing.

I removed the generated docs from this branch.

I am also thinking of using a special branch to publish the docs to. It will help keeping a clean commit history on master. What do you think?

@RobinWijnant RobinWijnant merged commit ac90563 into master Apr 30, 2020
@RobinWijnant RobinWijnant deleted the 6-basic-ci-setup branch April 30, 2020 20:55
@github-actions
Copy link

github-actions bot commented May 5, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Working on the build process released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Github action for documentation generation and deployment
2 participants