-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix merge pipeline #21
Conversation
d1ea731
to
9a38b4f
Compare
The failing git commit is caused by the EndBug/add-and-commit action. I have opened an issue on the repo. See EndBug/add-and-commit#27 |
Is there really not another way of deploying the docs? Because now the PR is always going to be cluttered with the built documentation files |
What do you mean with cluttered? Is the automatic commit bothering you? What do you propose? |
37818e8
to
ab42555
Compare
Right now there are 43 changes. But these are generated build files, meaning they will change every time a new build is done. This means that every pull request will have 40+ changes, which is really annoying to filter through when reviewing. |
This reverts commit 40e2f62.
Normally the commit with the generated doc folder only occurs after the merge in master. I wanted to test if it worked without waiting for the merge. This leaded to the docs already being commited in this branch. I think this was confusing. I removed the generated docs from this branch. I am also thinking of using a special branch to publish the docs to. It will help keeping a clean commit history on master. What do you think? |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See reopened issue #6
tsc --build
ortsc -b
is used to only update the changed files. The dist is always deleted so adding this flag is redundant. The verbose flag is also not needed imo.Closes #6