Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General component fixes #49

Merged
merged 10 commits into from
May 23, 2020
Merged

General component fixes #49

merged 10 commits into from
May 23, 2020

Conversation

bramvanhoutte
Copy link
Contributor

@bramvanhoutte bramvanhoutte commented May 22, 2020

Closes #46, closes #45

@bramvanhoutte bramvanhoutte added bug Something isn't working chore Making a script, doing a repeating task, refactor work labels May 22, 2020
@bramvanhoutte bramvanhoutte added this to the Sprint 3 milestone May 22, 2020
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #49 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   94.28%   94.23%   -0.06%     
==========================================
  Files           8        8              
  Lines         105      104       -1     
  Branches       18       18              
==========================================
- Hits           99       98       -1     
  Misses          6        6              
Impacted Files Coverage Δ
src/components/Input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1204931...4d804f6. Read the comment docs.

@bramvanhoutte bramvanhoutte merged commit 68fb252 into master May 23, 2020
@bramvanhoutte bramvanhoutte deleted the general-button-fixes branch May 23, 2020 17:08
@github-actions
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Making a script, doing a repeating task, refactor work released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button content isn't centered Font doesn't get applied on imported components
2 participants