Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing Unit Tests for Dicom Viewer Package
Problem with Jest configuration (solved)
whenever DicomViewer component is called in a test, there is a conflict with one of the dependencies of vtk.js (a dependency of cornerstone core, the fundamental framework used for implementing the dicom-viewer package). It seems that it has something to do with the fact that the version of vtk.js used seems to use the ESM syntax (https://kitware.github.io/vtk-js/docs/intro_vtk_as_es6_dependency.html). There are already a few other modules listed in “jest.config.ts” from ocis-web that probably also use this syntax.
--> Problem seems to be solved through #2 and #4
Related Issue
Motivation and Context
Writing unit tests for dicom-viewer to get good code coverage
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: