Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for Dicom Viewer package #1

Merged
merged 12 commits into from
Sep 29, 2023

Conversation

koebel
Copy link
Owner

@koebel koebel commented Aug 31, 2023

Description

Writing Unit Tests for Dicom Viewer Package

Problem with Jest configuration (solved)
whenever DicomViewer component is called in a test, there is a conflict with one of the dependencies of vtk.js (a dependency of cornerstone core, the fundamental framework used for implementing the dicom-viewer package). It seems that it has something to do with the fact that the version of vtk.js used seems to use the ESM syntax (https://kitware.github.io/vtk-js/docs/intro_vtk_as_es6_dependency.html). There are already a few other modules listed in “jest.config.ts” from ocis-web that probably also use this syntax.
--> Problem seems to be solved through #2 and #4

Related Issue

  • Implementing tests of dicom-viewer package of #9215
  • There is a draft PR for the current state of the implementation of the dicom-viewer package: #9615

Motivation and Context

Writing unit tests for dicom-viewer to get good code coverage

How Has This Been Tested?

  • running unit tests (implementation WiP)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests (WiP)

Checklist:

  • Code changes
  • Unit tests added (WiP)
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Fix issue with configuration of Jest
  • Write test code for the test cases that where identified

@koebel koebel added the help wanted Extra attention is needed label Aug 31, 2023
@koebel koebel self-assigned this Aug 31, 2023
Configuring jest.init.ts for DICOM viewer package
@koebel koebel removed the help wanted Extra attention is needed label Sep 1, 2023
@koebel koebel changed the title Problem with configuration of Jest in Implementation of Unit Tests for Dicom Viewer package Unit Tests for Dicom Viewer package Sep 1, 2023
@koebel koebel merged commit 5fe5b6f into DICOM-viewer-streamlined-app Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants