Animation Paths #418
Closed
Animation Paths #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for .animate). Added some basic examples under app.coffee in CactusFramer. Added a few useful functions to Utils.
…issue with animation paths and nested elements.
… functions as any argument value, which will be evaluated when the path node actually gets created.
…f the layer. Changed print -> toString.
…Fixed an issue with debug method which would incorrectly render anchor points with a zero coordinate. Added PathAnimation studio project to use in testing.
…amples to path animation project.
…e compatible with the new animateTo syntax. Cleaned up debug code.
…ring, instead of a Path instance. Fixed an issue that prevented debug markers from drawing if they were equal to 0.
…e of path in options vs truthiness.
…ntext and createSVGElement)
…bug element code.
Signed-off-by: Niels van Hoorn <[email protected]> # Conflicts: # framer/Animation.coffee # framer/Layer.coffee # test/tests/LayerAnimationTest.coffee
nvh
force-pushed
the
feature/animation-paths
branch
from
2e7a04c to
0c95112
Compare
Closed
tisho
reviewed
Sep 15, 2016
| backgroundColor: '#cbf' | ||
| borderRadius: 25 | ||
|
|
||
| layer.animateTo |
There was a problem hiding this comment.
Needs to be .animate now, right?
There was a problem hiding this comment.
Correct! Fixed in 6fdb987
|
Aside from a single method call in the path animation example, this is good to go! Thanks for dealing with all the merge conflicts. |
Signed-off-by: Niels van Hoorn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #151, but with the changed animation API (currently on master) merged in.