-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem using maven-jlink-plugin with POM-only junixsocket-core artifact #153
Comments
Hi @sblantipodi ! junixsocket-core is a POM-only dependency; it should not cause errors (the junixsocket jars are already modularized / contain module-info.class) |
As a workaround, you may replace the dependency to
|
@kohlschuetter thanks for the kind answer, I appreciate it. junixsocket is used inside the dbus-java lib that I use in my project. |
Demonstrates how to use jlink/jpackage with junixsocket. #153
Demonstrates how to use jlink/jpackage with junixsocket. #153
@sblantipodi Please see the new I'm using Please let me know how that goes for your project. — I didn't see the place where you exactly get the error (maybe you could point me at it?) On a related note: Did you look into using GraalVM native-image instead of jlink? That usually produces much more optimized code. junixsocket supports that, too. Other than that: Your ambient light project looks really cool! I was reading about such a tool just a few days ago. Good to see that junixsocket can play a small role there. Keep up the great work! |
@sblantipodi I also updated the demo POM with a profile triggering the bug. If you use a local snapshot build of maven-jlink-plugin with the patch applied, linking should work just fine. |
@kohlschuetter wow, great! thanks for the awesome work :) |
2.9.1 has been released, please verify. Thanks again for reporting! |
Hi all.
When I try to use jlink on software that uses junixsocket I get this error:
[ERROR] The given dependency C:\Users\sblantipodi.m2\repository\com\kohlschutter\junixsocket\junixsocket-core\2.8.3\junixsocket-core-2.8.3.pom does not have a module-info.java file. So it can't be linked.
any plan to add a module-info?
Thanks :)
The text was updated successfully, but these errors were encountered: