Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if BLAS GESV is not enabled (#837) #839

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

brian-kelley
Copy link
Contributor

We don't have fallback implementation for GESV. If no TPL provides
it, throw an exception. Partial fix for #837 - I would like to write a serial fallback when I get some time.

#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=711 run_time=135
clang-8.0-Pthread_Serial-release build_time=221 run_time=146
clang-9.0.0-Pthread-release build_time=138 run_time=65
clang-9.0.0-Serial-release build_time=151 run_time=53
cuda-10.1-Cuda_OpenMP-release build_time=918 run_time=136
cuda-11.0-Cuda_OpenMP-release build_time=973 run_time=136
cuda-9.2-Cuda_Serial-release build_time=921 run_time=197
gcc-7.3.0-OpenMP-release build_time=150 run_time=47
gcc-7.3.0-Pthread-release build_time=125 run_time=63
gcc-8.3.0-Serial-release build_time=149 run_time=50
gcc-9.1-OpenMP-release build_time=186 run_time=47
gcc-9.1-Serial-release build_time=182 run_time=60
intel-17.0.1-Serial-release build_time=501 run_time=62
intel-18.0.5-OpenMP-release build_time=486 run_time=51
intel-19.0.5-Pthread-release build_time=429 run_time=72

We don't have fallback implementation for GESV. If no TPL provides
it, throw an exception.
Copy link
Contributor

@vqd8a vqd8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brian-kelley for adding this.

@brian-kelley brian-kelley merged commit e5abe25 into kokkos:develop Oct 27, 2020
@brian-kelley brian-kelley deleted the GESV_Exception branch October 27, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants