-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support use of mdspan/mdarray.hpp header #376
base: stable
Are you sure you want to change the base?
Conversation
@@ -16,7 +16,7 @@ | |||
|
|||
#pragma once | |||
|
|||
#include "../mdspan" | |||
#include "mdspan/mdspan.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would work with just "../mdspan/mdspan.hpp"
.
The issue here is we switched the main headers to mdspan.hpp
instead of mdspan
, and I guess we missed this. I guess this only failed in Kokkos because we don't install the legacy mdspan
header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "../../mdspan/mdspan.hpp"
worked. Should I push that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think that would be good thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9582f5b has the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
CI Failure is unrelated, I suppose something changed and our CI broke... |
Using
#include "mdspan/mdarray.hpp"
provided by mdspan fails with the following error:A reproducer (
mdarrayReproducer.cpp
) is below:and its
CMakeLists.txt
:This PR fixes the compilation error, but I'm not sure if it is the correct fix. If it is merged and then brought into downstream Kokkos, it will resolve the issue discussed in kokkos/kokkos#7671.
All mdspan tests passed when using the following cmake commands with GCC 12.3.0 and CUDA 12.1.1.