Fix test_handle_nan sort error #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #12 +/- ##
=======================================
Coverage 85.52% 85.52%
=======================================
Files 93 93
Lines 5865 5865
Branches 640 640
=======================================
Hits 5016 5016
Misses 767 767
Partials 82 82 |
gordonhart
approved these changes
May 11, 2023
gordonhart
reviewed
May 11, 2023
| assert test_suite.description == new_description # not updated or cleared | ||
| assert test_suite.baseline_test_cases == [multi_version_test_case[1]] | ||
|
|
||
| with test_suite.edit(reset=True) as editor: | ||
| editor.add(multi_version_test_case[2], True) | ||
| assert test_suite.version == 4 | ||
| assert test_suite.version == 3 |
There was a problem hiding this comment.
Thank you for fixing these. I'll reconcile the not-quite-equivalent changes I've made on #7 in a rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue(s):
What change does this PR introduce and why?
Fix sort order caused test equality check failure
Please check if the PR fulfills these requirements