Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional unused definitions #485

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Remove additional unused definitions #485

merged 6 commits into from
Jan 26, 2024

Conversation

gordonhart
Copy link
Member

@gordonhart gordonhart commented Jan 26, 2024

More cleanup following #483, #424, and #347.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a30f67) 93.58% compared to head (7592200) 94.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #485      +/-   ##
==========================================
+ Coverage   93.58%   94.74%   +1.15%     
==========================================
  Files          83       80       -3     
  Lines        5145     5077      -68     
  Branches      710      709       -1     
==========================================
- Hits         4815     4810       -5     
+ Misses        258      195      -63     
  Partials       72       72              
Flag Coverage Δ
integration 76.20% <100.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonhart gordonhart marked this pull request as ready for review January 26, 2024 21:41
@gordonhart gordonhart requested a review from a team as a code owner January 26, 2024 21:41
@gordonhart gordonhart merged commit e5f2726 into trunk Jan 26, 2024
51 checks passed
@gordonhart gordonhart deleted the gh/coverage-maxxing branch January 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants