chore: add back special datatype for timestamp #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nankolena
changed the title
munkyshi
approved these changes
Jan 6, 2025
yifanwu-kolena
approved these changes
Jan 6, 2025
munkyshi
deleted the
nan/kol-3547-sdk-handle-timestamp-classes-in-json-serde-default-iso-second
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue(s)
Resolves KOL-3547. Should not merge before 7824 is resolved.
What change does this PR introduce and why?
Add back #730 (revert the revert)
Add #731 to assume the time string is of ISO 8601 format for parsing when the format is not specified.
Updated doc:
Please check if the PR fulfills these requirements