Add client side support for the DocumentAsset type #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerpeterson
approved these changes
Jan 7, 2025
kolena/asset.py
Outdated
| """ | ||
| A document file in a cloud bucket or served at a URL. | ||
|
|
||
| Only `.txt` and `.pdf` file types are supported. |
There was a problem hiding this comment.
y27choi
approved these changes
Jan 7, 2025
munkyshi
deleted the
andrew/kol-7840-add-client-support-for-document-assets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue(s)
Fixes: KOL-7840
What change does this PR introduce and why?
Introduces client side support for the DocumentAsset type.
This allows users to attach TXT and PDF documents to their datapoints, without requiring it to be the primary data value.
Please check if the PR fulfills these requirements