Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAG example using financebench #738

Merged
merged 11 commits into from
Jan 10, 2025
Merged

RAG example using financebench #738

merged 11 commits into from
Jan 10, 2025

Conversation

y27choi
Copy link
Contributor

@y27choi y27choi commented Jan 8, 2025

Linked issue(s)

N/A

What change does this PR introduce and why?

Introduces RAG example using financebench

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@y27choi y27choi changed the title [WIP] RAG example using financebench RAG example using financebench Jan 8, 2025
@y27choi y27choi marked this pull request as ready for review January 8, 2025 21:27
@y27choi y27choi requested a review from a team as a code owner January 8, 2025 21:27
@y27choi y27choi requested a review from brianshen3 January 9, 2025 14:30
examples/dataset/retrieval_augmented_generation/README.md Outdated Show resolved Hide resolved
using the `--help` flag for more information:

```shell
$ uv run python3 retrieval_augmented_generation/upload_results.py --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current default behaviour with no model specified only uploads the baseline. I think the default should run all 3 models. We may want to briefly define what baseline, qme, and query_decomp are here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this script to be used to learn how to upload one model's results which is why it's designed to run only one. Is there a reason why you want to run all three by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal either way imo, but in a live demo it'd be nice to do all 3 at once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I won't make this change but I did add more information about the model results and how to format raw model results file in the README if you could take a look at it.

examples/dataset/retrieval_augmented_generation/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marko-polo-cheno marko-polo-cheno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@brianshen3 brianshen3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my trunk. Worked great!

Copy link
Contributor

@munkyshi munkyshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping

@munkyshi
Copy link
Contributor

munkyshi commented Jan 9, 2025

For the speaker diarization CI error, you'll probably have to rebase of latest trunk -- there was a dep I had to pin to get the CI passing again.

@y27choi y27choi merged commit a812289 into trunk Jan 10, 2025
57 checks passed
@y27choi y27choi deleted the yoohee/rag-example branch January 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants