Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logic to handle labeled answers #742

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

added logic to handle labeled answers #742

wants to merge 1 commit into from

Conversation

brianshen3
Copy link
Contributor

Linked issue(s)

What change does this PR introduce and why?

Handle compute metrics for labeled answers in the script.

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@brianshen3 brianshen3 requested a review from a team as a code owner January 13, 2025 19:09
@marko-polo-cheno
Copy link
Contributor

With a partially labelled dataset and uv run python3 retrieval_augmented_generation/upload_results.py query_decomp --dataset-name financebenchmarknew --evaluate, I am seeing kolena> Failed to import module for data type 'SPECIAL/TIMESTAMP'.

Also seeing metrics indicate the correct page is retrieved, but the wrong document is retrieved which is contradictory.
image

@marko-polo-cheno marko-polo-cheno removed their request for review January 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkyshi munkyshi Awaiting requested review from munkyshi

@moelgendy moelgendy Awaiting requested review from moelgendy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianshen3 @marko-polo-cheno