Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local endpoint implementation #177

Merged
merged 6 commits into from
Dec 21, 2022
Merged

Local endpoint implementation #177

merged 6 commits into from
Dec 21, 2022

Conversation

EdwinGuayacan
Copy link
Contributor

@EdwinGuayacan EdwinGuayacan commented Dec 16, 2022 •
edited
Loading

Fixes #100

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This was linked to issues Dec 16, 2022
Local endpoint implementation #100
Closed
Public PACT interface #150
Closed
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch 2 times, most recently from f993013 to 4e12645 Compare December 16, 2022 15:56
@EdwinGuayacan EdwinGuayacan changed the title Add local endpoitn and PACT API Add local endpoitnt and PACT API Dec 16, 2022
@EdwinGuayacan EdwinGuayacan changed the title Add local endpoitnt and PACT API Add local endpoitn Dec 16, 2022
@EdwinGuayacan EdwinGuayacan changed the title Add local endpoitn Add local endpoitnt Dec 16, 2022
@EdwinGuayacan EdwinGuayacan changed the title Add local endpoitnt Add local endpoint Dec 20, 2022
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch 3 times, most recently from 3cc3cbd to 3a12344 Compare December 20, 2022 17:40
@EdwinGuayacan
Add local endpoitn and PACT API
e939aa3 
Add new function in Cap and modify JSON format (kommitters#168)

* Add new function in Cap type and JSON format changes

add local endpoint and pact API
@EdwinGuayacan
fixing tests
9902a38
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch 3 times, most recently from 76d4202 to a49fb01 Compare December 20, 2022 19:32
@EdwinGuayacan EdwinGuayacan changed the title Add local endpoint Local endpoint implementation Dec 20, 2022
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch 2 times, most recently from f457a95 to 2f2313d Compare December 20, 2022 20:06
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from 2f2313d to 737a6eb Compare December 20, 2022 20:13
@EdwinGuayacan EdwinGuayacan changed the base branch from v0.10 to v0.11 December 20, 2022 20:21
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 20, 2022 20:24
@EdwinGuayacan @miguelnietoa
Update docs and Readme
620e143 
Co-authored-by: Miguel Nieto A <[email protected]>
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from c1e0074 to 620e143 Compare December 21, 2022 14:06
miguelnietoa
miguelnietoa requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwinGuayacan good job! Comments added ⬇️

@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from ba42ef9 to 49d452d Compare December 21, 2022 17:05
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from 49d452d to 868134b Compare December 21, 2022 20:41
miguelnietoa
miguelnietoa requested changes Dec 21, 2022
View reviewed changes
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from 05a4fed to 9ee02d7 Compare December 21, 2022 21:25
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from 9ee02d7 to e4d4f6f Compare December 21, 2022 21:44
@EdwinGuayacan EdwinGuayacan force-pushed the 100-local-endpoint-implementation branch from e4d4f6f to 681140d Compare December 21, 2022 21:55
@miguelnietoa miguelnietoa removed a link to an issue Dec 21, 2022
Public PACT interface #150
Closed
5 tasks
@EdwinGuayacan EdwinGuayacan merged commit fcd796f into kommitters:v0.11 Dec 21, 2022
EdwinGuayacan added a commit to EdwinGuayacan/kadena.ex that referenced this pull request Dec 22, 2022
@EdwinGuayacan @miguelnietoa
Local endpoint implementation (kommitters#177)
0175b67 
* Add local endpoint implementation

Co-authored-by: Miguel Nieto A <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanhurtado10 juanhurtado10 juanhurtado10 approved these changes

@miguelnietoa miguelnietoa miguelnietoa approved these changes

@L-Zuluaga L-Zuluaga Awaiting requested review from L-Zuluaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local endpoint implementation
3 participants
@EdwinGuayacan @juanhurtado10 @miguelnietoa