-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Indication for Current Menu Items (issue #33) #35
Conversation
The style that I would like to achieve is this:
|
pkg/frontend/src/App.tsx
Outdated
@@ -83,31 +88,31 @@ export default function App() { | |||
<Divider/> | |||
<List> | |||
<ListItem key="Claims" disablePadding> | |||
<ListItemButton component={RouterLink} to="/claims"> | |||
<ListItemButton component={RouterLink} to="/claims" sx={{ backgroundColor: isLinkActive('/claims') ? '#312e67' : 'transparent' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplication does not look good.
Can you extract function that would return full sx style? Because I'd like to get the style similar to Komodor app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code cooks perfect now. Thank you very much for contribution! |
ThankYou! |
Fixes #33
Added Highlight or Indications For Current Menu Items,
Used Color : #312e67,
Github.mp4