Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup NominatimConnector #518

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Code cleanup NominatimConnector #518

merged 4 commits into from
Dec 13, 2020

Conversation

lonvia
Copy link
Collaborator

@lonvia lonvia commented Dec 9, 2020

  • moves NominatimResult and ImportThread code into separate files
  • trims AddressRow further to required parts
  • use lambda notation where possible
  • clean up of minor formatting issues and code smells

Also adds tests for interpolation computation.

lonvia added 4 commits December 5, 2020 17:28
@lonvia
factor out NominatimResult in a separate file
8f17b67 
Also adds initial tests for the new class.
@lonvia
modernize code and remove unused parts
77057ef 
parseDocument() was only used in tests that are no longer there.
Also improves formatting of code and uses Java8 syntax.
@lonvia
factor out code for import threads
fd87818 
Also fixes some issues on the way reported by sonar.
@lonvia
remove unused place_id from AddressRow
f03f398
@lonvia lonvia merged commit 28b5068 into komoot:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lonvia