Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: simple synonym list #581

Closed
wants to merge 2 commits into from
Closed

Experimental: simple synonym list #581

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49abf6f
new command-line option to supply a synonym file
lonvia Jun 5, 2021
b322a62
lowercase synonym list before loading
lonvia Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/de/komoot/photon/elasticsearch/IndexSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public IndexSettings setSynonyms(String synonymFile) throws IOException {
if (line.indexOf(' ') >= 0) {
throw new RuntimeException("Synonym list must not contain any spaces or multi word terms.");
}
synonyms.put(line);
synonyms.put(line.toLowerCase());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line.toLowerCase(Locale.ROOT) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "whatever ES uses", to be precise.

}

JSONObject filters = (JSONObject) settings.optQuery("/analysis/filter");
Expand Down