Update index mappings and settings on startup #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new class which encapsulate loading and applying the index settings. Adds new functionality to update the settings.
Factors out the code for loading the index mapping in its own class. Adds code to reload the mapping when Photon is started as a server. Also adds tests that the custom languages are applied and hints how to modify index settings and mappings.
Databases without the global property document have no information about the languages used on initial import, so there is no way to reproduce the original mapping correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is some versioning of the database, we can safely update the index settings and mappings on startup of the Photon server. This allows to use the same database dump for different versions of Photon that might use different search analyzers. The synonym analyser in #581 already applied a similar tactics.
I've added some hints for developers in CONTRIBUTING.md how to handle settings and mapping changes.