Reorganise code to properly encapsulate elasticsearch #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now unified with the Search/ReverseHandler given that both together encapulate the ES-specific code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shifts around the existing code, so that access to the elasticsearch library is now completely restricted to the
de.komoot.photon.elasticsearchpackage. Theseverclass becomes the main component responsible for creating any objects related to ES processing. The query classes are reorganised to have a clean break between webserver and database access. The*ElasticSearcherclasses are gone and it's code is merged into the ES-specific classes.There is still some reorganisation work to do for the result handling. The conversion to a Geocode JSON result shouldn't be done in the ES-specific part.