Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sync/errgroup #124

Merged
merged 17 commits into from
Sep 2, 2019
Merged

use sync/errgroup #124

merged 17 commits into from
Sep 2, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Aug 8, 2019

Thank you for contributing to meli.
Every contribution to meli is important to us.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to meli, and meli agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that meli shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed/added/removed?)

  • Use golang.org/x/sync/errgroup for managing goroutine lifecycles.
    TODO: fix todo's

Why(Why did you change/add/remove it?)

  • it looks to be better at it

@komuw
Copy link
Owner Author

komuw commented Aug 8, 2019

The ci failure is

go: verifying github.com/docker/[email protected]: checksum mismatch
	downloaded: h1:yo5xsA6ZV6CbKtryIlqxspayS5FLU3cHS0SpbFQORbQ=
	go.sum:     h1:v8cqbUr9o2JRb+4rIDWPmncYtTLuXZZprbD7ggflCU8=
Exited with code 1

I think it will be resolved when w move to Go1.13.
go1.12 -> go1.13 has some mod hash mismatches(i read that somewhere, i think)

komuw added 16 commits August 8, 2019 15:33
* Set up CI with Azure Pipelines

[skip ci]

* m

* m

* m

* m

* m

* m3

* m4

* m6

* m

* m9

* m11

* m11

* m13

* m15

* m17

* m19

* m21

* later

* g1

* g2

* d

* sudo

* sudo

* s1

* s3

* s5

* s8

* m3

* s9

* s9

* s9

* s9

* s9

* s9

* m3

* m3

* m3

* m3

* m3

* m3

* m3

* Update azure-pipelines.yml

* md

* m3

* m6

* m6

* mdrrwr42

* mdrrwr42
@komuw komuw merged commit fd29212 into master Sep 2, 2019
@komuw komuw deleted the use-sync/errgroup branch September 2, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant