Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpm-ostree OCI-TA Task variant #1502

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Add rpm-ostree OCI-TA Task variant #1502

merged 2 commits into from
Oct 16, 2024

Conversation

zregvart
Copy link
Contributor

Generated for version 0.2 only.

Reference: https://issues.redhat.com/browse/EC-924

@zregvart zregvart requested a review from cgwalters October 11, 2024 11:51
zregvart
zregvart commented Oct 14, 2024
View reviewed changes
task/rpm-ostree-oci-ta/0.2/rpm-ostree-oci-ta.yaml
exit 1
fi

<"/var/workdir/source"/image-digest tee "$(results.IMAGE_DIGEST.path)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in the shell formatter does this, it's a generated file and this is mostly esthetics so I don't think it is worth troubleshooting, but yell at me if you think it matters...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is shfmt the tool used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use https://github.com/mvdan/sh

@cgwalters
Copy link
Contributor

Note we have https://issues.redhat.com/browse/BIFROST-408 which would allow us to get rid of this task entirely.

What's the timeframe for this? I would say it's possible within a few weeks we'd gain sufficient knowledge to say whether or not we can execute on deprecating and eventually removing this task entirely.

@lmilbaum
Copy link

lmilbaum commented Oct 15, 2024 •
edited by openshift-ci bot
Loading

Note we have https://issues.redhat.com/browse/BIFROST-408 which would allow us to get rid of this task entirely.

What's the timeframe for this? I would say it's possible within a few weeks we'd gain sufficient knowledge to say whether or not we can execute on deprecating and eventually removing this task entirely.

AFAIK, this PR is expected to land today. BIFROST-400 is blocked by this PR.

@lcarva
Copy link
Contributor

lcarva commented Oct 15, 2024

To avoid blocking different efforts, let's go ahead and get this Task in. We can remove/deprecate it if/when we do so for the rpm-ostree Task as well.

@zregvart zregvart enabled auto-merge October 16, 2024 07:47
@zregvart
Copy link
Contributor Author

Taking the comments above as approval

@zregvart zregvart added this pull request to the merge queue Oct 16, 2024
Merged via the queue into konflux-ci:main with commit a4c73ec Oct 16, 2024
14 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Oct 16, 2024
Merged
@zregvart zregvart deleted the issue/EC-924 branch October 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkdchen tkdchen tkdchen left review comments

@lcarva lcarva lcarva approved these changes

@taylormadore taylormadore Awaiting requested review from taylormadore

@tisutisu tisutisu Awaiting requested review from tisutisu

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zregvart @cgwalters @lmilbaum @lcarva @tkdchen