Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using rolling release of EC #1842

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Using rolling release of EC #1842

merged 1 commit into from
Jan 22, 2025

Conversation

joejstuart
Copy link
Contributor

Since there's not an easy way to update ec use the rolling release.

https://issues.redhat.com/browse/EC-1066

@joejstuart joejstuart requested a review from a team as a code owner January 20, 2025 19:50
@chmeliik
Copy link
Contributor

We pinned to a specific release in #1788, because the stable release has been broken at least twice that I can remember (missing the executable assets)

@joejstuart
Copy link
Contributor Author

We pinned to a specific release in #1788, because the stable release has been broken at least twice that I can remember (missing the executable assets)

We got it fixed here. enterprise-contract/ec-cli#2244. Without regular updates of the cli, it can fall behind the policies which can cause issues.

@joejstuart
Copy link
Contributor Author

@chmeliik I'm going to add an additional verification step to help prevent this also. https://issues.redhat.com/browse/EC-1082

chmeliik
chmeliik previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming more robust releases of ec-cli this LGTM

@joejstuart
Using rolling release of EC.
727715d 
Since there's not an easy way to update ec
use the rolling release. This copies the
ec binary from the ec-cli image instead
of downloading it from Github.

https://issues.redhat.com/browse/EC-1066
@joejstuart
Copy link
Contributor Author

@chmeliik I misunderstood the issue. It was with the Github release process and not with the ec-cli image. This latest change copies the binary from the ec-cli image bypassing the download from Github. The verification step after the image is built is also added. https://github.com/enterprise-contract/ec-cli/pull/2280/files

chmeliik
chmeliik approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this seems better 👍

@chmeliik chmeliik added this pull request to the merge queue Jan 22, 2025
Merged via the queue into konflux-ci:main with commit ed7403a Jan 22, 2025
16 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joejstuart @chmeliik