Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EC-885): step-report to step-report-json #1405

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

zregvart
Copy link
Contributor

Description

We removed the YAML output in EC-568, this is a followup to use the JSON logs instead.

Issue ticket number and link

Resolves: https://issues.redhat.com/browse/EC-885

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

n/a

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

We removed the YAML output in EC-568, this is a followup to use the JSON
logs instead.

Resolves: https://issues.redhat.com/browse/EC-885
@zregvart
Copy link
Contributor Author

/retest

1 similar comment
@zregvart
Copy link
Contributor Author

/retest

@zregvart
Copy link
Contributor Author

The integration test seems to be failing with:

[User error] PipelineRun konflux-qe-team-tenant/konflux-e2e-jc2xv-n6dqq parameters have mismatching types with Pipeline konflux-qe-team-tenant/konflux-e2e-tests's parameters: parameters have inconsistent types : [ocp-version konflux-test-infra-secret cloud-credential-key quality-dashboard-api machine-type replicas]

@psturc
Copy link
Member

psturc commented Sep 25, 2024

I removed the oras-container and region parameters that were present in the ITS (but not in the pipeline definition)
/retest

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem, lcarva, simonbaird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Contributor

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit ea8e6b2 into konflux-ci:main Sep 26, 2024
13 checks passed
@zregvart zregvart deleted the issue/EC-885 branch September 26, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants