feat(RELEASE-1205): create engine rule for release catalog #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Qi <[email protected]>
|
Skipping CI for Draft Pull Request. |
jinqi7
force-pushed
the
RELEASE-1205
branch
3 times, most recently
from
247af61 to
6086fc2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/retest |
theflockers
reviewed
Oct 11, 2024
| func GetPairedCommitSha(repoForPairing string, rctx *rulesengine.RuleCtx) string { | ||
| var pullRequests []gh.PullRequest | ||
|
|
||
| url := fmt.Sprintf("https://api.github.com/repos/redhat-appstudio/%s/pulls?per_page=100", repoForPairing) |
There was a problem hiding this comment.
should this be also changed to konflux-ci? Or not yet. Not idea, just asking.
Signed-off-by: Jing Qi <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psturc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 11, 2024
tnevrlka
pushed a commit
to tnevrlka/e2e-tests
that referenced
this pull request
Oct 17, 2024
…i#1420) * fix: update_repo in release const.go Signed-off-by: Jing Qi <[email protected]> * feat(RELEASE-1205): create engine rule for release catalog Signed-off-by: Jing Qi <[email protected]> --------- Signed-off-by: Jing Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: