Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXUI-256): support component.spec.containerImage as latestImage #67

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

testcara
Copy link
Contributor

@testcara testcara commented Jan 9, 2025

The integration service recently migrated from using the component's spec.containerImage field to store the latest image to using the component's status.lastPromotedImage field.

The patch support the component.spec.containerImage as the latestImage when it's valid.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (7c5807c) to head (5d40f39).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/ComponentDetails/tabs/ComponentDetails.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   80.01%   80.11%   +0.10%     
==========================================
  Files         569      570       +1     
  Lines       21379    21452      +73     
  Branches     5294     5050     -244     
==========================================
+ Hits        17107    17187      +80     
+ Misses       4247     4241       -6     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 80.11% <95.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be backward compatible. Right now I have a component that doesn't have any status. We should check for lastPromotedImage first if that doesn't exist use the spec.containerImage.
image

@testcara testcara force-pushed the KFLUXUI-256 branch 2 times, most recently from 5cfcb0b to dd1c162 Compare January 14, 2025 04:29
@testcara testcara changed the title chore(KFLUXUI-256): replace component.spec.containerImage to component.status.lastPromotedImage chore(KFLUXUI-256): support component.spec.containerImage as latestImage Jan 14, 2025
src/utils/component-utils.ts Outdated Show resolved Hide resolved
src/utils/__tests__/component-utils.spec.ts Outdated Show resolved Hide resolved
@sahil143 sahil143 added this pull request to the merge queue Jan 17, 2025
@sahil143 sahil143 removed this pull request from the merge queue due to a manual request Jan 17, 2025
@sahil143 sahil143 merged commit 4609b37 into konflux-ci:main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants