Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deletemodal): update microcopy based content #91

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(deletemodal): update microcopy based content #91

merged 1 commit into from
Jan 23, 2025

Conversation

abhinandan13jan
Copy link
Contributor

Fixes

Fixes - KFLUXUI-258 & KONFLUX-6195

Description

Updates content for ApplicationDeleteModal & ComponentDeleteModal

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2025-01-20 at 6 32 41 PM Screenshot 2025-01-20 at 6 32 09 PM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@sahil143
Copy link
Collaborator

/retest

@StanislavJochman
Copy link
Contributor

LGTM.

@sahil143 sahil143 merged commit 3ae7eee into konflux-ci:main Jan 23, 2025
3 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavJochman StanislavJochman StanislavJochman approved these changes

@sahil143 sahil143 sahil143 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhinandan13jan @sahil143 @StanislavJochman