Newitcv output #83
Merged
Newitcv output #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default assignment of function parameters retains the value "=", and when assigning values to the columns of the dplyr::tibble I chose to replace the assignment "=" with the value "<-", (this change can be retained or not).
The main change comes from the assignment of variables with T changed to "TRUE", not all = changed to <-, the main principle is: function parameter assignment with "=", variable assignment for "<-". " In addition, for the definition of the matrix "byrow = TRUE" this way usually use "=", instead of the assignment symbol <-. This is a way of passing a function parameter without using the assignment "<-" symbol.
change“ est_eff = est_eff,
beta_threshold = beta_threshold”
to
est_eff <- est_eff,
beta_threshold <- beta_threshold
Maintain "=" for function parameter assignments and "<-" for variable assignments.
Maintain "=" for function parameter assignments and "<-" for variable assignments.
T to TRUE;F to FALSE
T to TRUE
T to TRUE; F to FALSE
fixed formatting issues with output
…elper_output_dataframe Update helper_output_dataframe.R
…elper_plot_threshold Update helper_plot_threshold.R
….R-patch-1 Update tkonfound.R
…R-patch-1 Update test_pse.R
…Rpatch-1 Update test_cop.R
…itivity_ln.Rpatch-1 Update test_sensitivity_ln.R
…_fig.R-patch-1 Update tkonfound_fig.R
…onlinear_auxiliary Update nonlinear_auxiliary.R
Merge branch 'master' of https://github.com/konfound-project/konfound # Conflicts: # DESCRIPTION
fix the bug when est_eff_start = 0 and needtworows
revised warning message for non-linear model in konfound
no errors now in devtools::check()
qinyun-lin
force-pushed
the
newitcv_output
branch
from
a768b55 to
fc199f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.