use name of storageConfig in k8s PVC resource name #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
changed the title
erdrix
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds the PVC name specified in the
NifiCluster.Spec.StorageConfigs.Nameto the name of the k8sPersistentVolumeClaimso they're more easily identified. It also adds the name to the PVC metadata labels.Additionally, I fixed a bug where the PVC
generateNameconfig didn't end in a hyphen so PVCs have a name that resemblesmy-nifi-1-storagew7frbinstead ofmy-nifi-1-storage-w7frb.With this PR, the PVC names will now look like
my-nifi-1-content-repo-storage-w7frbif theNifiCluster.Spec.StorageConfigs.Nameiscontent-repo.Why?
To more easily identify what each persistent volume claim is used for. This is useful when building Grafana dashboards monitoring persistent volumes.
Checklist