Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic detection of k8s prior 1.21 #144

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Aug 23, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Detection of Kubernetes version to revert some changes if the version is prior 1.21.

Why?

To be compatible with version prior 1.21 of Kubernetes.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx marked this pull request as ready for review August 23, 2022 14:07
@cannonpalms
Copy link
Contributor

LGTM outside of my question about generated files.

@mh013370
Copy link
Member

LGTM as well

@juldrixx juldrixx merged commit a7c7d4b into master Aug 23, 2022
@juldrixx juldrixx deleted the feature/automatic_k8s_prior_1_21_detection branch August 23, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants