Removing instances where reconcile requeue didn't honor the interval time #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
reviewed
Aug 26, 2022
|
The only question i really have is whether we change the default interval for some of these that had the Perhaps the controllers are treating the "requeue" case separately from the normal error or success interval cases. |
|
LGTM. This ought to reduce load on the control plane as well 👍 |
|
This seems to work well in our test clusters. 👍 |
cannonpalms
approved these changes
Aug 26, 2022
erdrix
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
There were instances where the reconcile requeue didn't honor the configured interval. I've removed these to bring it in line with all other reconcile requeues
Checklist