Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/ParameterContext] Add parameter context inheritance #165

Merged
merged 17 commits into from
Sep 24, 2022
Merged

[Feature/ParameterContext] Add parameter context inheritance #165

merged 17 commits into from
Sep 24, 2022

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Sep 17, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Feature to allow the management of parameter context inheritance through the operator.

Why?

To enable the use of an additional feature of NiFi

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 17, 2022
@juldrixx juldrixx changed the title Feature/parameter context refs Add parameter context inheritance Sep 17, 2022
@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 17, 2022
@juldrixx juldrixx marked this pull request as ready for review September 17, 2022 23:20
@juldrixx juldrixx requested a review from erdrix September 17, 2022 23:21
@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 17, 2022
@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 20, 2022
@juldrixx juldrixx requested a review from mh013370 September 20, 2022 14:55
mh013370
mh013370 reviewed Sep 20, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 20, 2022
mh013370
mh013370 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@mh013370 mh013370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Adding a new optional field, so i don't think there are any CRD API issues.

@juldrixx juldrixx changed the title Add parameter context inheritance [Feature/ParameterContext] Add parameter context inheritance Sep 21, 2022
@konpyutaika konpyutaika deleted a comment from gitguardian bot Sep 24, 2022
@juldrixx juldrixx requested a review from erdrix September 24, 2022 19:39
@juldrixx juldrixx merged commit f4bf712 into master Sep 24, 2022
@juldrixx juldrixx deleted the feature/parameter_context_refs branch September 24, 2022 22:34
@Roger1uphealth Roger1uphealth mentioned this pull request Nov 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mh013370 mh013370 mh013370 approved these changes

@erdrix erdrix Awaiting requested review from erdrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juldrixx @erdrix @mh013370