Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive ping #344

Closed
daniele-athome opened this issue Mar 11, 2015 · 3 comments
Closed

Adaptive ping #344

daniele-athome opened this issue Mar 11, 2015 · 3 comments
Assignees
@daniele-athome
Labels
bug Something isn't working
Milestone
3.0-beta9

Comments

@daniele-athome
Copy link
Member

With 30 mins timeouts there are still problems with some mobile carriers.
Implement an adaptive ping algorithm that tests the current connection and adapts to the current situation (store optimal values so they can be reused).
@daniele-athome daniele-athome added the bug Something isn't working label Mar 11, 2015
@daniele-athome daniele-athome self-assigned this Mar 11, 2015
@daniele-athome daniele-athome added this to the 3.0-beta9 milestone Mar 11, 2015
@daniele-athome
Copy link
Member Author

Consider also using tcp keep alive or very small pings.

https://code.google.com/p/chromium/codesearch#chromium/src/google_apis/gcm/engine/heartbeat_manager.cc

@daniele-athome daniele-athome mentioned this issue Mar 18, 2015
Closed
7 tasks
@daniele-athome
Copy link
Member Author

Under way in branch feature/adaptive-ping.

daniele-athome added a commit that referenced this issue Mar 19, 2015
@daniele-athome
Very rough implementation of adaptive ping (#344)
f27d251 
Signed-off-by: Daniele Ricci <[email protected]>
@daniele-athome
Copy link
Member Author

Starting from 30 minutes, Kontalk will half that value if a ping fails, and it will multiply it by 1.5 if a ping succeed.
Allowed range: 5 - 30 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniele-athome daniele-athome

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0-beta9
Development

No branches or pull requests
1 participant
@daniele-athome