-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sliding pane #543
Feature/sliding pane #543
Conversation
ContactsListActivity remains as picker activity.
Isnt there a redesign with #412 anyway? [but sounds nice] |
Any chance for a screenshot so non-developers could comment? If you are okay with that, of course. |
@h-2 true, but I didn't want to merge with another feature branch @TheLastProject nothing much to see. In the conversation list view you click the "new conversation" icon, the contact list slides in from the left side. Choose a contact, swipe back or click the "back" button to go back. |
9e70d54
to
13fe830
Compare
Thanks @abika that's great work! I'll begin reviewing it and merging it to master ASAP. |
I created another branch merging the sliding pane with material design (3171992). [The layout gets a bit complicated with the new toolbar]
A button is needed here, we can even disable swiping in the conversation view to force using the button. But honestly, I thought the old button in the toolbar was fine. It was more unobtrusive, which is good as creating new conversations will happen seldom if the app is used for a while (the new icon is better though). Besides that the new design looks really great btw.! Can't thing of any improvements |
android:launchMode="singleTop" | ||
android:theme="@style/Theme.Light"> | ||
android:theme="@style/Theme.Light" | ||
android:configChanges="orientation|screenSize"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for adding this configChanges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes: if the contact list is open and the screen rotates, the action bar will be reset to the settings for the conversion list. These configChanges prevent this by simply ignoring the screen changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration changes can lead to some unexpected results when are not handled by the system (e.g. resources are not reloaded). I'll adjust the code to make it happen automatically according to the activity lifecycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thx, I didn't know how to do that. In the onCreate() call caused by the screen rotation the sliding pane was set to be closed even though it was visibly open.
Signed-off-by: Daniele Ricci <[email protected]>
Signed-off-by: Daniele Ricci <[email protected]>
As promised in #371 here is a new layout for the main view: The contact list is now a sliding side view for the conversation list.
Details:
Tested with normal and dual-pane view + orientation change in every possible situation.
[Sometimes the syncing process takes very long (60sec). Annoying in the view, but that's another problem]
Maybe a nice TODO: show the slider from the right side. But I couldn't found an easy solution for that.