Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sliding pane #543

Merged
merged 7 commits into from
Sep 7, 2015
Merged

Feature/sliding pane #543

merged 7 commits into from
Sep 7, 2015

Conversation

abika
Copy link
Member

@abika abika commented Aug 31, 2015

As promised in #371 here is a new layout for the main view: The contact list is now a sliding side view for the conversation list.

Details:

  • most code in the contacts activity was moved to either the conversation (list) activity or to the fragment
  • the conversation activity contains now both fragments, for conversation and contact list
  • the contacts list activity is still there but only for picking a contact (invitation is not possible here anymore, but whatever)

Tested with normal and dual-pane view + orientation change in every possible situation.
[Sometimes the syncing process takes very long (60sec). Annoying in the view, but that's another problem]

Maybe a nice TODO: show the slider from the right side. But I couldn't found an easy solution for that.

@h-2
Copy link

h-2 commented Aug 31, 2015

Isnt there a redesign with #412 anyway? [but sounds nice]

@TheLastProject
Copy link
Contributor

Any chance for a screenshot so non-developers could comment? If you are okay with that, of course.

@abika
Copy link
Member Author

abika commented Aug 31, 2015

@h-2 true, but I didn't want to merge with another feature branch

@TheLastProject nothing much to see. In the conversation list view you click the "new conversation" icon, the contact list slides in from the left side. Choose a contact, swipe back or click the "back" button to go back.
device-2015-08-31-205819

@abika abika force-pushed the feature/sliding-pane branch from 9e70d54 to 13fe830 Compare August 31, 2015 19:36
@daniele-athome
Copy link
Member

Thanks @abika that's great work! I'll begin reviewing it and merging it to master ASAP.
By the way do you have any proposal for merging this to the material branch? I mean do you think still using a floating action button would be ideal in this situation? Any other UI insight might be useful.

@daniele-athome daniele-athome added the enhancement New feature or request label Sep 1, 2015
@daniele-athome daniele-athome modified the milestones: 3.0.4, 3.0.5 Sep 1, 2015
@abika
Copy link
Member Author

abika commented Sep 1, 2015

I created another branch merging the sliding pane with material design (3171992). [The layout gets a bit complicated with the new toolbar]

I mean do you think still using a floating action button would be ideal in this situation? Any other UI insight might be useful.

A button is needed here, we can even disable swiping in the conversation view to force using the button.

But honestly, I thought the old button in the toolbar was fine. It was more unobtrusive, which is good as creating new conversations will happen seldom if the app is used for a while (the new icon is better though).

Besides that the new design looks really great btw.! Can't thing of any improvements

@daniele-athome daniele-athome self-assigned this Sep 7, 2015
android:launchMode="singleTop"
android:theme="@style/Theme.Light">
android:theme="@style/Theme.Light"
android:configChanges="orientation|screenSize">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for adding this configChanges?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes: if the contact list is open and the screen rotates, the action bar will be reset to the settings for the conversion list. These configChanges prevent this by simply ignoring the screen changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration changes can lead to some unexpected results when are not handled by the system (e.g. resources are not reloaded). I'll adjust the code to make it happen automatically according to the activity lifecycle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thx, I didn't know how to do that. In the onCreate() call caused by the screen rotation the sliding pane was set to be closed even though it was visibly open.

@daniele-athome daniele-athome merged commit 435a6fa into master Sep 7, 2015
@daniele-athome daniele-athome deleted the feature/sliding-pane branch September 7, 2015 16:37
@daniele-athome daniele-athome mentioned this pull request Sep 12, 2015
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants