Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

378 Fix problem with IDateTimeContent BSON serialization/deserialization #379

Merged

Conversation

dzmitryk-kontent-ai
Copy link
Contributor

Motivation

#378

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@dzmitryk-kontent-ai dzmitryk-kontent-ai requested review from pokornyd and a team as code owners August 3, 2023 13:26
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #379 (afcabb2) into master (46abeb7) will increase coverage by 0.06%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   88.48%   88.55%   +0.06%     
==========================================
  Files         128      128              
  Lines        2753     2761       +8     
  Branches      345      345              
==========================================
+ Hits         2436     2445       +9     
  Misses        185      185              
+ Partials      132      131       -1     
Files Changed Coverage Δ
...Delivery/ContentItems/DateTimes/DateTimeContent.cs 100.00% <ø> (ø)
....Delivery.Abstractions/DeliveryClientExtensions.cs 100.00% <100.00%> (ø)
...very.Caching/Extensions/SerializationExtensions.cs 89.28% <100.00%> (+2.32%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzmitryk-kontent-ai dzmitryk-kontent-ai force-pushed the 378-IDateTimeContent_bson_serialization branch from 2e813f7 to 6a56b31 Compare August 3, 2023 13:32
@Simply007 Simply007 self-requested a review August 3, 2023 13:40
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dzmitryk-kontent-ai dzmitryk-kontent-ai force-pushed the 378-IDateTimeContent_bson_serialization branch from 6a56b31 to afcabb2 Compare August 3, 2023 13:56
@dzmitryk-kontent-ai dzmitryk-kontent-ai merged commit c712ba7 into master Aug 4, 2023
@dzmitryk-kontent-ai dzmitryk-kontent-ai deleted the 378-IDateTimeContent_bson_serialization branch August 4, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants