Adds missing headers input to webhook, fixes transition_to type a…

…nd extends test query
kontent-ai · May 7, 2024 · 8836e1b · 8836e1b
1 parent 1d520b4
commit 8836e1b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 8 deletions.
diff --git a/lib/contracts/webhook-contracts.ts b/lib/contracts/webhook-contracts.ts
@@ -81,21 +81,21 @@ export namespace WebhookContracts {
         languages?: SharedContracts.IReferenceObjectContract[];
     }
 
-    export interface IContentTypeFilters{
+    export interface IContentTypeFilters {
         content_types?: SharedContracts.IReferenceObjectContract[];
     }
 
-    export interface ITaxonomyFilters{
+    export interface ITaxonomyFilters {
         taxonomies?: SharedContracts.IReferenceObjectContract[];
     }
 
-    export interface ILanguageFilters{
+    export interface ILanguageFilters {
         languages?: SharedContracts.IReferenceObjectContract[];
     }
 
     export interface IContentItemActions {
         action: WebhookContentItemAction;
-        transition_to: {
+        transition_to?: {
             workflow_identifier: SharedContracts.ICodenameIdReferenceContract;
             step_identifier: SharedContracts.ICodenameIdReferenceContract;
         };

diff --git a/lib/models/webhook/webhook.models.ts b/lib/models/webhook/webhook.models.ts
@@ -44,8 +44,9 @@ export namespace WebhookModels {
         name: string;
         secret: string;
         url: string;
-        last_modified?: string;
         enabled?: boolean;
+        headers?: IWebhookHeader[];
+
         delivery_triggers: {
             slot: WebhookDeliveryTriggerSlots;
             events: WebhookDeliveryTriggersEvents;

diff --git a/test/browser/webhook/add-webhook.spec.ts b/test/browser/webhook/add-webhook.spec.ts
@@ -18,6 +18,11 @@ describe('Add webhook', () => {
                     asset: { enabled: true, actions: ['metadata_changed', 'created'] },
                     content_item: {
                         enabled: true,
+                        filters: {
+                            collections: [{ codename: 'y' }],
+                            content_types: [{ codename: 'x' }],
+                            languages: [{ codename: 'z' }]
+                        },
                         actions: [
                             {
                                 action: 'published',
@@ -43,7 +48,14 @@ describe('Add webhook', () => {
                         filters: { taxonomies: [{ codename: 'z' }] }
                     }
                 },
-                url: 's'
+                url: 's',
+                enabled: true,
+                headers: [
+                    {
+                        key: 'name',
+                        value: 'value'
+                    }
+                ]
             })
             .toPromise();
     });
@@ -80,16 +92,16 @@ describe('Add webhook', () => {
         expect(webhook.name).toEqual(originalItem.name);
         expect(webhook.lastModified).toEqual(undefined);
         expect(webhook.url).toEqual(originalItem.url);
+
+        // type checks
         expect(webhook.deliveryTriggers.asset).toEqual(jasmine.any(WebhookModels.WebhookDeliveryTriggersAsset));
         expect(webhook.deliveryTriggers.contentItem).toEqual(
             jasmine.any(WebhookModels.WebhookDeliveryTriggersContentItem)
         );
         expect(webhook.deliveryTriggers.contentType).toEqual(
             jasmine.any(WebhookModels.WebhookDeliveryTriggersContentType)
         );
-        expect(webhook.deliveryTriggers.events).toEqual(originalItem.delivery_triggers.events);
         expect(webhook.deliveryTriggers.language).toEqual(jasmine.any(WebhookModels.WebhookDeliveryTriggersLanguage));
-        expect(webhook.deliveryTriggers.slot).toEqual(originalItem.delivery_triggers.slot);
         expect(webhook.deliveryTriggers.taxonomy).toEqual(jasmine.any(WebhookModels.WebhookDeliveryTriggersTaxonomy));
     });
 });