Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change element types to discriminated union #144

Merged
merged 2 commits into from
Mar 21, 2024
Merged

feat: change element types to discriminated union #144

merged 2 commits into from
Mar 21, 2024

Conversation

Nickm615
Copy link
Collaborator

Motivation

Which issue does this fix? Fixes #137

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Nickm615 Nickm615 requested review from IvanKiral, Enngage and a team as code owners March 15, 2024 15:16
@Enngage Enngage merged commit 7d35f3e into master Mar 21, 2024
1 check passed
@Enngage Enngage deleted the 137-change-element-types-to-discriminated-union branch March 21, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanKiral IvanKiral Awaiting requested review from IvanKiral IvanKiral is a code owner

@Enngage Enngage Awaiting requested review from Enngage Enngage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change element types to be a discriminated union of all the element types
2 participants
@Nickm615 @Enngage