Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #107 - Enable further customization of the CustomTypeProvider #111

Merged
merged 2 commits into from
Aug 12, 2021
Merged

fixes #107 - Enable further customization of the CustomTypeProvider #111

merged 2 commits into from
Aug 12, 2021

Conversation

Sevitas
Copy link
Contributor

@Sevitas Sevitas commented Jul 22, 2021

Motivation

Enables further customization of the CustomTypeProvider

Fixes #107

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Check whether generated CustomTypeProvider contains:

  1. GetType and GetCodename methods are marked as virtual
  2. _codenames dictionary is marked as protected
  3. valid C# code

@Sevitas Sevitas requested a review from a team July 22, 2021 10:59
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #111 (770b3ed) into master (83a6202) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files          13       13           
  Lines         632      632           
  Branches       55       55           
=======================================
  Hits          514      514           
  Misses        101      101           
  Partials       17       17           
Impacted Files Coverage Δ
...t.ModelGenerator.Core/TypeProviderCodeGenerator.cs 78.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a6202...770b3ed. Read the comment docs.

@MiroKentico
Copy link

MiroKentico commented Jul 22, 2021

From my point of view, implementation is correct.

@Simply007 Simply007 requested a review from MiroKentico July 27, 2021 10:04
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is ok. Just one note - I have adjusted the description so that when the pull request is merged the linked issue is closed as well:

I have one question though - where you would add the information about the extensibility of the type provider? I would put the main information into Delivery SDK Wiki - probably this section: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models#generating-custom-type-providers and then just link this information in a note from the kontent-generators-net Readme file - @Sevitas @MiroKentico what do you think?

@Sevitas
Copy link
Contributor Author

Sevitas commented Jul 27, 2021

ity of the type provider? I would put the main information into Delivery SDK Wiki - probably this sec

It makes sense to put it into wiki and link it to the readme.

@Sevitas
Copy link
Contributor Author

Sevitas commented Aug 9, 2021

updated readme
updated documentation
@Simply007

@Simply007
Copy link
Contributor

updated readme
updated documentation
@Simply007

I have reverted the readme change - 31e02dd + just adjusted link to wiki - I guess it is fine, we don!t want the same information on two places.

Rephrase in the wiki page to make it a bit more maintainable: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models/_compare/c64ad99dd2c325a911617e3ad31a34269673b527...c0e09400372dc4e248e61fd25a5e113bfc3074e8

@Simply007 Simply007 self-requested a review August 10, 2021 09:33
@Sevitas
Copy link
Contributor Author

Sevitas commented Aug 12, 2021

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

@Simply007
Copy link
Contributor

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

Make sence to me. Let's add it.

@Sevitas
Copy link
Contributor Author

Sevitas commented Aug 12, 2021

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

Make sence to me. Let's add it.

https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Strong-Types-Explained-%E2%80%93-Code-Generator/_compare/27937f5138305cfbe8516eb7ee77927710614907...ff2584666e02a860e0d475ba822ec738cba89aba

@Simply007
Copy link
Contributor

Cool, let's merge it - @Sevitas - will you do the donors?

@Sevitas Sevitas merged commit a8f1852 into kontent-ai:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable further customization of the CustomTypeProvider
4 participants