-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #107 - Enable further customization of the CustomTypeProvider #111
fixes #107 - Enable further customization of the CustomTypeProvider #111
Conversation
…ename methods virtual
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 13 13
Lines 632 632
Branches 55 55
=======================================
Hits 514 514
Misses 101 101
Partials 17 17
Continue to review full report at Codecov.
|
From my point of view, implementation is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is ok. Just one note - I have adjusted the description so that when the pull request is merged the linked issue is closed as well:
I have one question though - where you would add the information about the extensibility of the type provider? I would put the main information into Delivery SDK Wiki - probably this section: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models#generating-custom-type-providers and then just link this information in a note from the kontent-generators-net Readme file - @Sevitas @MiroKentico what do you think?
It makes sense to put it into wiki and link it to the readme. |
updated readme |
I have reverted the readme change - 31e02dd + just adjusted link to wiki - I guess it is fine, we don!t want the same information on two places. Rephrase in the wiki page to make it a bit more maintainable: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models/_compare/c64ad99dd2c325a911617e3ad31a34269673b527...c0e09400372dc4e248e61fd25a5e113bfc3074e8 |
I've found another place link which might be edited (codesnippet). @Simply007 what do you think? |
Make sence to me. Let's add it. |
|
Cool, let's merge it - @Sevitas - will you do the donors? |
Motivation
Enables further customization of the CustomTypeProvider
Fixes #107
Checklist
How to test
Check whether generated CustomTypeProvider contains: