Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 subpages #127

Merged
merged 7 commits into from
Jan 13, 2022
Merged

122 subpages #127

merged 7 commits into from
Jan 13, 2022

Conversation

Sevitas
Copy link
Contributor

@Sevitas Sevitas commented Dec 15, 2021

Motivation

Fixes #122

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Have an type with a Subpages element and generate models. Newly generated model contains subpages element

@Sevitas Sevitas requested a review from a team December 15, 2021 12:34
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #127 (2898110) into master (3f48775) will increase coverage by 0.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   83.29%   84.19%   +0.90%     
==========================================
  Files          20       21       +1     
  Lines         772      791      +19     
  Branches       76       81       +5     
==========================================
+ Hits          643      666      +23     
+ Misses        107      104       -3     
+ Partials       22       21       -1     
Impacted Files Coverage Δ
...ntico.Kontent.ModelGenerator.Core/CodeGenerator.cs 58.55% <100.00%> (+1.50%) ⬆️
...ico.Kontent.ModelGenerator.Core/Common/Property.cs 100.00% <100.00%> (ø)
...t.ModelGenerator.Core/Helpers/ElementTypeHelper.cs 100.00% <100.00%> (ø)
...lGenerator.Core/Helpers/ManagementElementHelper.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48775...2898110. Read the comment docs.

@Sevitas Sevitas requested a review from Simply007 December 15, 2021 12:37
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync about the idea for type definition for delivery vs. Subpages.

@Sevitas Sevitas merged commit a1b0278 into master Jan 13, 2022
@Sevitas Sevitas deleted the 122_subpages branch January 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Subpages element
2 participants