Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/138 guidelines element #139

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Bug/138 guidelines element #139

merged 2 commits into from
Mar 10, 2022

Conversation

Sevitas
Copy link
Contributor

@Sevitas Sevitas commented Mar 10, 2022

Motivation

Which issue does this fix? Fixes #138

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Sevitas Sevitas requested a review from a team March 10, 2022 11:24
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #139 (ad773bb) into vNext (fb33841) will decrease coverage by 0.27%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            vNext     #139      +/-   ##
==========================================
- Coverage   87.29%   87.01%   -0.28%     
==========================================
  Files          23       23              
  Lines         842      847       +5     
  Branches       78       79       +1     
==========================================
+ Hits          735      737       +2     
- Misses         88       91       +3     
  Partials       19       19              
Impacted Files Coverage Δ
...ico.Kontent.ModelGenerator.Core/Common/Property.cs 96.61% <66.66%> (-3.39%) ⬇️
...o.Kontent.ModelGenerator.Core/CodeGeneratorBase.cs 49.36% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb33841...ad773bb. Read the comment docs.

@Sevitas Sevitas requested a review from Simply007 March 10, 2022 11:25
@Sevitas Sevitas merged commit 56a5502 into vNext Mar 10, 2022
@Sevitas Sevitas deleted the bug/138_guidelines_element branch March 10, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants