Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration #155

Merged
merged 15 commits into from
Aug 1, 2022
Merged

Migration #155

merged 15 commits into from
Aug 1, 2022

Conversation

pokornyd
Copy link
Member

@pokornyd pokornyd commented Jul 31, 2022

Motivation

Migration

  • Legacy references updated
  • Documentation updated
  • Wiki moved to docs
  • Packages updated

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@pokornyd pokornyd requested a review from Simply007 July 31, 2022 13:21
@pokornyd
Copy link
Member Author

are we going to rename the assembly from 'KontentModelGenerator' to something else as well, or are we keeping that?

@Simply007
Copy link
Contributor

are we going to rename the assembly from 'KontentModelGenerator' to something else as well, or are we keeping that?

Let's keep it like that - as we keep kontent as a command for Kontent.ai CLI

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #155 (61d9fa7) into master (6fb52e3) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   88.21%   88.09%   -0.12%     
==========================================
  Files          25       25              
  Lines         840      840              
  Branches       76       76              
==========================================
- Hits          741      740       -1     
  Misses         83       83              
- Partials       16       17       +1     
Impacted Files Coverage Δ
...ontent.Ai.ModelGenerator.Core/CodeGeneratorBase.cs 48.10% <ø> (ø)
...Generator.Core/Common/ClassCodeGeneratorFactory.cs 100.00% <ø> (ø)
...t.Ai.ModelGenerator.Core/Common/ClassDefinition.cs 100.00% <ø> (ø)
...enerator.Core/Common/InvalidIdentifierException.cs 100.00% <ø> (ø)
.../Kontent.Ai.ModelGenerator.Core/Common/Property.cs 96.61% <ø> (ø)
...nerator.Core/Configuration/CodeGeneratorOptions.cs 100.00% <ø> (ø)
...nt.Ai.ModelGenerator.Core/DeliveryCodeGenerator.cs 74.68% <ø> (ø)
...erator.Core/Generators/Class/ClassCodeGenerator.cs 100.00% <ø> (ø)
...ore/Generators/Class/DeliveryClassCodeGenerator.cs 100.00% <ø> (ø)
...Generators/Class/DeliveryClassCodeGeneratorBase.cs 100.00% <ø> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Simply007 Simply007 merged commit c3256c1 into master Aug 1, 2022
@Simply007 Simply007 deleted the migration branch August 1, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants