Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare upgrade #140

Merged
merged 17 commits into from
Oct 17, 2022
Merged

Prepare upgrade #140

merged 17 commits into from
Oct 17, 2022

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #138 #137 #139

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@1e1486f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #140   +/-   ##
========================================
  Coverage          ?   8.70%           
========================================
  Files             ?      64           
  Lines             ?     942           
  Branches          ?      35           
========================================
  Hits              ?      82           
  Misses            ?     857           
  Partials          ?       3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IvanKiral IvanKiral marked this pull request as ready for review October 6, 2022 07:50
@pokornyd pokornyd self-requested a review October 14, 2022 12:47
@pokornyd
Copy link
Member

Some legacy references fixed, otherwise looking good.

Copy link
Member

@pokornyd pokornyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed there's a Wiki. should be updated and moved to root folder docs

@pokornyd
Copy link
Member

disabled the wiki as it references no longer existing sources and materials. it primarily explains preview URL configuration, which is thoroughly explained in Kontent.ai docs

@IvanKiral IvanKiral merged commit ef93459 into master Oct 17, 2022
@IvanKiral IvanKiral deleted the prepare-upgrade branch October 17, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Css file is missing
3 participants