feat: add support for Argo Rollouts #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumil Paranjpay <[email protected]> fix: add untracked files Signed-off-by: Soumil Paranjpay <[email protected]> fix: use argo rollouts library structs Signed-off-by: Soumil Paranjpay <[email protected]>
Signed-off-by: Soumil Paranjpay <[email protected]>
|
Thanks for making a pull request! 😃 |
Signed-off-by: Soumil Paranjpay <[email protected]>
Akash-Nayak
requested changes
Nov 21, 2023
| k8s.io/apiserver v0.26.2 // indirect | ||
| k8s.io/cli-runtime v0.23.1 // indirect | ||
| k8s.io/cli-runtime v0.25.8 // indirect |
There was a problem hiding this comment.
Are we going with v0.24.2 or v0.25.8? Also, please recheck if everything works well if you change the version.
There was a problem hiding this comment.
If I'm not wrong, these are indirect dependencies so they have to be 25.8
Signed-off-by: Soumil Paranjpay <[email protected]>
Signed-off-by: Soumil Paranjpay <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
- Coverage 14.81% 14.76% -0.06%
==========================================
Files 90 90
Lines 8321 8379 +58
==========================================
+ Hits 1233 1237 +4
- Misses 6770 6824 +54
Partials 318 318 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.