Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement single monolog interface #21

Closed
wants to merge 3 commits into from
Closed

implement single monolog interface #21

wants to merge 3 commits into from

Conversation

basert
Copy link

@basert basert commented Apr 26, 2015

Pullrequest for issue koraktor/steam-condenser#266

@koraktor
Copy link
Owner

Seems awkward to use the SteamCondenser class for this (which is pure metadata as of now).
Additionally, I don't think that having the logger as an additional constructor argument on each class that needs logging is a good idea.

Complying to PSR-3 seems much more reasonable IMO.

@koraktor koraktor mentioned this pull request Apr 27, 2015
Open
@basert basert closed this Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basert @koraktor