Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GIfDrawable subclassing #399

Merged
merged 5 commits into from
Apr 2, 2017

Conversation

stanmots
Copy link
Contributor

@stanmots stanmots commented Apr 2, 2017

This closes #398

@codecov-io
Copy link

codecov-io commented Apr 2, 2017

Codecov Report

Merging #399 into master will increase coverage by 0.11%.
The diff coverage is 16.32%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #399      +/-   ##
=========================================
+ Coverage    4.23%   4.35%   +0.11%     
=========================================
  Files          26      27       +1     
  Lines        1322    1332      +10     
  Branches      119     119              
=========================================
+ Hits           56      58       +2     
- Misses       1263    1271       +8     
  Partials        3       3
Impacted Files Coverage Δ
...rc/main/java/pl/droidsonroids/gif/InputSource.java 0% <0%> (ø) ⬆️
...rc/main/java/pl/droidsonroids/gif/GifDrawable.java 0% <0%> (ø) ⬆️
.../java/pl/droidsonroids/gif/GifDrawableBuilder.java 100% <100%> (+82.05%) ⬆️
...ain/java/pl/droidsonroids/gif/GifDrawableInit.java 15.9% <15.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac86d1c...622471f. Read the comment docs.

@koral-- koral-- merged commit 587ca0d into koral--:master Apr 2, 2017
@koral--
Copy link
Owner

koral-- commented Apr 3, 2017

Thanks, this change is available in version 1.2.7-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants