Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EdgeDetection api #1483

Merged
merged 16 commits into from
Oct 12, 2022
Merged

Add EdgeDetection api #1483

merged 16 commits into from
Oct 12, 2022

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Dec 5, 2021 •
edited
Loading

Changes

Add EdgeDetection api using Dexined

https://github.com/xavysp/DexiNed/blob/d944b70eb6eaf40e22f8467c1e12919aa600d8e4/model.py

https://www.computer.org/csdl/proceedings-article/wacv/2020/09093290/1jPbjFHmwi4

amiga_edge

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba edgarriba added feature request New feature or request module: contrib 1 Priority 1 🚨 High priority labels Jan 7, 2022
@ducha-aiki
Copy link
Member

@edgarriba is there anything left here to do? Pretrained weights?

@edgarriba
Copy link
Member Author

that was the missing pieces -- the weights for this network were huge (>100Mb) which didn't fit well without git-lfs (which we don't support). I'm aware that @xavysp published a new and much lighter version of this method. Worth to explore to include that one instead

@ducha-aiki
Copy link
Member

@edgarriba I can host weights at my website, that is not a problem

@edgarriba
Copy link
Member Author

edgarriba commented Oct 5, 2022 •
edited
Loading

the weights are in the links found here: https://github.com/xavysp/DexiNed#test

in a gdrive , which i remember now that we had trouble also with xavi to use it with torch hub, Yes, better to host in your website

@edgarriba edgarriba mentioned this pull request Oct 5, 2022
Closed
@ducha-aiki
Copy link
Member

@edgarriba I have uploaded it here http://cmp.felk.cvut.cz/~mishkdmy/models/DexiNed_BIPED_10.pth
So, if you add it the wieghts and fix lint, we are good to go?

@edgarriba edgarriba marked this pull request as ready for review October 11, 2022 09:27
@edgarriba edgarriba changed the title add edge detection api Add EdgaeDetection api Oct 11, 2022
@edgarriba edgarriba changed the title Add EdgaeDetection api Add EdgeDetection api Oct 11, 2022
@edgarriba
Copy link
Member Author

@ducha-aiki good to go

ducha-aiki
ducha-aiki approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@ducha-aiki ducha-aiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see couple of organization comments

examples/edge_detection/main.py Show resolved Hide resolved
test/filters/test_filters.py Show resolved Hide resolved
@ducha-aiki ducha-aiki enabled auto-merge (squash) October 12, 2022 13:17
@ducha-aiki ducha-aiki disabled auto-merge October 12, 2022 14:29
@ducha-aiki ducha-aiki merged commit 627ebca into master Oct 12, 2022
@ducha-aiki ducha-aiki deleted the feat/edge_detection branch October 12, 2022 14:29
@renovate renovate bot mentioned this pull request Nov 4, 2022
Open
1 task
johnnv1 pushed a commit to johnnv1/kornia that referenced this pull request Apr 5, 2023
@edgarriba
Add EdgeDetection api (kornia#1483)
7c6259c 
* add edge detection api
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmytro Mishkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducha-aiki ducha-aiki ducha-aiki approved these changes

Assignees
No one assigned
Labels
1 Priority 1 🚨 High priority feature request New feature or request module: contrib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarriba @ducha-aiki