Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Zca inverse transform fix #695

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Conversation

ceroytres
Copy link
Contributor

@ceroytres ceroytres commented Oct 6, 2020

Description

I noticed that I forgot to include the regularization (epsilon) in computing the inverse ZCA transform. I updated the test to include different epsilon values.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.

If there are any questions regarding code style or other conventions check out our
summary.

  • Did you discuss the functionality or any breaking changes before ?
  • Pass all tests: did you test in local ? make test
  • Unittests: did you add tests for your new functionality ?
  • Documentations: did you build documentation ? make build-docs
  • Implementation: is your code well commented and follow conventions ? make lint
  • Docstrings & Typing: has your code documentation and typing ? make mypy
  • Update notebooks & documentation if necessary

KorniaTeam

KorniaTeam workflow
  • Assign correct label
  • Assign PR to a reviewer
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, Typing, Linting, Documentation, Environment)
  • Does the implementation follow kornia design conventions?
  • Is the documentation complete enough ?
  • Are the tests covering simple and corner cases ?

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgarriba edgarriba changed the title Zca inverse transform fix [Fix] Zca inverse transform fix Oct 8, 2020
@edgarriba edgarriba merged commit 68badf3 into kornia:master Oct 8, 2020
edgarriba added a commit that referenced this pull request May 30, 2021
* fix inv transform

* update zca test

Co-authored-by: Edgar Riba <[email protected]>
edgarriba added a commit to edgarriba/kornia that referenced this pull request Jul 6, 2021
* fix inv transform

* update zca test

Co-authored-by: Edgar Riba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants